Attribute(s)Impl usage and API
------------------------------

                 Key: DIRSERVER-833
                 URL: https://issues.apache.org/jira/browse/DIRSERVER-833
             Project: Directory ApacheDS
          Issue Type: Task
            Reporter: Emmanuel Lecharny
            Priority: Critical


We should modify the Attribute(s)Impl API and usage. Those classes should never 
be used outside of the server, and we should use BasicAttribute(s) instance 
instead.
When we receive a BasicAttribute(s) instance, we should convert them to an 
Attribute(s)Impl before working on attributes. 

A second point is that operations like contains(), get() or equals() must use 
the matchingRules instead of doing straight comparizons of case sensitive 
strings.

Last, not least, we should not use the attribute name to do operations on 
attributes, but their OID. Operations like 
"objectClass".equals( trim( attributeType.getName() ).toLowerCase )
should not be used. It's much better to define a static final OBJECT_CLASS_OID 
somewhere and do a 
OBJECT_CLASS_OID.equals( attributeType.getOid() )

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to