Ole,

Alex don't like ATTRIBUTE_TYPE and OBJECT_CLASS prostfix, and I understand
his rationnal.

That means : don't commit this change.

PS. There are two unwritten rules you should always think about before
proposing a change :
- if it's not broken, don't fix it
- respect existing conventions even if you don't like them

I should have asked Alex before telling you to move on. My bad.

Emmanuel

On 4/19/07, Ole Ersoy <[EMAIL PROTECTED]> wrote:

OK - Cool - I'll make it ATTRIBUTE_TYPE.

Emmanuel Lecharny wrote:
> Just as suggested by pam, AT stand for ATTRIBUTE_TYPE, not ATTRIBUTE
>
> On 4/19/07, *Emmanuel Lecharny* < [EMAIL PROTECTED]
> <mailto:[EMAIL PROTECTED]>> wrote:
>
>     Ole Ersoy a écrit :
>
>      > I went ahead and scanned the constants files.
>      >
>      > If everyone is cool with it, I'll go ahead and
>      > update the interfaces so that:
>      >
>      > AT > ATTRIBUTE
>      > OC > OBJECT_CLASS
>      >
>      > and recommit.
>      >
>      > Sound ok?
>
>     Go for it, but before committing, run
>     mvn -Dintegration test
>     on the top level project.
>
>     If the test (20 minutes) is ok, then commit.
>
>     Emmanuel
>
>
>
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com <http://www.iktek.com>




--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

Reply via email to