[ 
https://issues.apache.org/jira/browse/DIRSERVER-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612126#action_12612126
 ] 

Marc DeXeT commented on DIRSERVER-577:
--------------------------------------

It was a problem ! I have stop my LdapProtocoleProvider  based proxy  
development because of this coupling ! 

> Loosen LdapProtocolProvider-ServerLdapContext coupling.
> -------------------------------------------------------
>
>                 Key: DIRSERVER-577
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-577
>             Project: Directory ApacheDS
>          Issue Type: Improvement
>          Components: ldap
>    Affects Versions: 1.0-RC1
>            Reporter: Marc DeXeT
>            Priority: Minor
>             Fix For: 1.5.3
>
>
> LdapProtocoleProvider is heavely coupled to ServerLdapContext, even the 
> package name has changed to 'server'.
> To allow more custom override, I suggest to do 'instanceof' test at least on 
> LdapContext.lookup("") result.
> You can see such direct casting into SessionRegistry
> /.../
> else if ( ctx != null && allowAnonymous )
>         {
>             ServerLdapContext slc = null;
>             if ( ! ( ctx instanceof ServerLdapContext ) )
>             {
>                 slc = ( ServerLdapContext ) ctx.lookup( "" );
>             }
>             else
>             {
>                 slc = ( ServerLdapContext ) ctx;
>             }
> /.../

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to