[ 
https://issues.apache.org/jira/browse/DIRSERVER-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622162#action_12622162
 ] 

gerke forcare commented on DIRSERVER-1229:
------------------------------------------

I just thought that it might be useful to know that the server and client times 
(error.getServerTime()/error.getClientTime()) have been swapped. (diff would 
have shown, but it's hard to see from the code snippets given above. Sorry.

> KerberosProtocolHandler has server and client swapped in logErrorMessage
> ------------------------------------------------------------------------
>
>                 Key: DIRSERVER-1229
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1229
>             Project: Directory ApacheDS
>          Issue Type: Bug
>          Components: kerberos
>    Affects Versions: 1.5.3
>         Environment: source-code review
>            Reporter: gerke forcare
>            Priority: Minor
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> One can read in the source 
> (org.apache.directory.server.kerberos.protocol.KerberosProtocolHandler 
> logErrorMessage):
>             sb.append( "Responding to request with error:" );
>             sb.append( "\n\t" + "explanatory text:      " + 
> error.getExplanatoryText() );
>             sb.append( "\n\t" + "error code:            " + 
> error.getErrorCode() );
>             sb.append( "\n\t" + "clientPrincipal:       " + 
> error.getClientPrincipal() );
>             sb.append( "\n\t" + "client time:           " + 
> error.getServerTime() );
>             sb.append( "\n\t" + "serverPrincipal:       " + 
> error.getServerPrincipal() );
>             sb.append( "\n\t" + "server time:           " + 
> error.getClientTime() );
> which might need to read:
>             sb.append( "Responding to request with error:" );
>             sb.append( "\n\t" + "explanatory text:      " + 
> error.getExplanatoryText() );
>             sb.append( "\n\t" + "error code:            " + 
> error.getErrorCode() );
>             sb.append( "\n\t" + "clientPrincipal:       " + 
> error.getClientPrincipal() );
>             sb.append( "\n\t" + "client time:           " + 
> error.getClientTime() );
>             sb.append( "\n\t" + "serverPrincipal:       " + 
> error.getServerPrincipal() );
>             sb.append( "\n\t" + "server time:           " + 
> error.getServerTime() );

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to