[jira] Commented: (DIRSTUDIO-540) Patch to copy source bundles along with bundles during

[Felix Knecht (JIRA)]

    [ 
https://issues.apache.org/jira/browse/DIRSTUDIO-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763928#action_12763928
 ] 

Felix Knecht commented on DIRSTUDIO-540:
----------------------------------------

I'm not sure, if this is the expected result, but running the patched plugin on 
the studio trunk I get only two (2 !) artifact sources missing. Can this really 
be correct?

[WARNING] Following source artifact is not available in the local repository 
'org.eclipse.core.filesystem.linux:x86_64:jar:sources:1.0.100.v20080604-1400'
[WARNING] Following source artifact is not available in the local repository 
'org.eclipse.swt.gtk.linux:x86_64:jar:sources:3.5.0.v3550b'

Reformatted logging to make more clear which artifact sources are missing (from 
AbstractStudioMojo):

    protected void completeArtifactItems( List<ArtifactItem> artifactItems, 
boolean relaxed )
        throws MojoExecutionException
    {
        List<String> warnings = new ArrayList<String>();
        // Get and complete artifacts
        for ( Iterator<ArtifactItem> artifactItem = artifactItems.iterator(); 
artifactItem.hasNext(); )
        {
            ArtifactItem item = artifactItem.next();
            try
            {
                // make sure we have a version.
                if ( StringUtils.isEmpty( item.getVersion() ) )
                {
                    fillMissingArtifactVersion( item );
                }
                item.setArtifact( this.getArtifact( item ) );
            }
            catch ( Exception e )
            {
                if ( relaxed )
                {
                    warnings.add( "Following source artifact is not available 
in the local repository '"
                        + item.getGroupId() + ":" + item.getArtifactId() + ":" 
+ item.getType() + ":"
                        + item.getClassifier() + ":" + item.getVersion() + "'" 
);
                }
                else
                {
                    throw new MojoExecutionException(
                        "Following source artifact is not available in the 
local repository '" + item.getGroupId()
                            + ":" + item.getArtifactId() + ":" + item.getType() 
+ ":" + item.getClassifier() + ":"
                            + item.getVersion() + "'", e );
                }
            }
        }

        if ( relaxed && !warnings.isEmpty() )
        {
            for ( String warn : warnings )
            {
                getLog().warn( warn );
            }
        }
    }


> Patch to copy source bundles along with bundles during 
> -------------------------------------------------------
>
>                 Key: DIRSTUDIO-540
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-540
>             Project: Directory Studio
>          Issue Type: Improvement
>         Environment: N/A
>            Reporter: Hasan Ceylan
>            Assignee: Felix Knecht
>         Attachments: studio-source-include.patch
>
>
> studio-maven-plugin currently does not copy source artifacts.
> The attached path deals with that.
> It introduces two configuration parameters to copy-eclipse-artifact mojo:
> 1) includeSources : if we should include source artifacts
> 2) relaxed: if we should keep going is a source artifact cannot be found
> Regards,
> Hasan Ceylan

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.