[ 
https://issues.apache.org/jira/browse/DIRSERVER-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788624#action_12788624
 ] 

Emmanuel Lecharny commented on DIRSERVER-1434:
----------------------------------------------

There is a slight problem in the current impl, and it should be tested : when 
adding a LoadableSchemaObject, the FQCN must be updated after the addition.

We inject an instance of SO here, so the FQCN and the byteCode are not 
necessarily present, this is the reason why they should be updated.

OTOH, I'm not sure if we should update the byteCode field... 

One more test we should do is to check that the FQCN is equal to the instance 
of LoadableSchemaObject. Right now, this is not done.


> Create tests for addition of N/C/SC in SchemaManager
> ----------------------------------------------------
>
>                 Key: DIRSERVER-1434
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1434
>             Project: Directory ApacheDS
>          Issue Type: Test
>    Affects Versions: 2.0.0-RC1
>            Reporter: Emmanuel Lecharny
>             Fix For: 2.0.0-RC1
>
>
> We need to add tests for C/N/SC addition :
> - addition of a brand new SO
> - addition of a new SO with an existing OID : should get an error
> - addition of a new SO with an existing class name : should get an error
> - addition of a new SO with an existing name : should get an error

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to