On Sat, May 15, 2010 at 11:15 AM, Stefan Seelmann <[email protected]>wrote:
> Let's add a comment into each empty catch block to describe why the > exception is catched and not handled so another developer can see the > reason. > > +1 > Kiran Ayyagari wrote: > > hi Felix, > > > >> In LdapCoreSessionConnection.java we have multiple constructs like (see > >> below). The methods declares tho throw 2 Exceptions, but with this > >> construct they are never thrown. Is this on purpose? > > yeah, cause in this implementation of LdapConnection interface there > > is no network layer > > involved and the throws clause is just there to adhere to the > > interface signatures > > > > can fill the catch block with a log statement if required to avoid > > false positives in the reports > > > > Kiran Ayyagari > > -- Alex Karasulu My Blog :: http://www.jroller.com/akarasulu/ Apache Directory Server :: http://directory.apache.org Apache MINA :: http://mina.apache.org To set up a meeting with me: http://tungle.me/AlexKarasulu
