-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 >> I suggest setting such constants final as well. >> Are there any objections? >> > > No objection. static final is a must have. > > One thing to consider though : check if Enum could be an option. It's > probaby better in many cases (of course not for a singe value).
Using Enums as already suggested by Alan [|1] for I18n stuff might have impacts quite all over the place. I suggest to fix it ATM as "static final" and create a Jira entry to refactor all those kind of static final/Enums as separate task. Otherwise we will have a mix of it in the code. WDYT? [1] http://www.archivum.info/[email protected]/2010-03/00282/Re-About-I18n.html -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkvxJYwACgkQ2lZVCB08qHFGQgCeLwMCSE9vFwDQ1PdgbayNx2ID eaAAoKmf/crgFj81jVKdlyFYRA8Nzb35 =SC78 -----END PGP SIGNATURE-----
