[
https://issues.apache.org/jira/browse/DIRSTUDIO-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885026#action_12885026
]
Stefan Seelmann commented on DIRSTUDIO-668:
-------------------------------------------
Here are my comments:
General notes:
- don't use the implicit toString() method in your write methods. You need to
inspect each object and find out the important information. For DN objects the
toString() method works, but better use getName() that returns the user
provided string.
- to serialize enums you can just use the implicit name() method to get the
name of the constant. This name can then be used in the deserialization code to
get the enum object from the string: valueOf(String name).
- I don't see that you write controls. But that's not that important for the
first shot, you can add them later.
writeBindRequest():
- message.getCredentials() returns an byte[], the toString() method won't work
here because it just returns something like "[...@10987197".
writeAddRequest():
- to write the entry you need to extract all attributes from the entry and all
values from the attributes. Also note that values can be string or byte[].
writeModifyRequest():
- write the attribute type and all values of each modification item. Note that
it is valid that the attribute doesn't contain any value
> Create an XML Parser/Writer using Dom4J for LDAP Protocol requests/responses
> ----------------------------------------------------------------------------
>
> Key: DIRSTUDIO-668
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-668
> Project: Directory Studio
> Issue Type: Task
> Components: studio-proxy
> Reporter: Pierre-Arnaud Marcelot
> Assignee: Keheliya Gallaba
>
> In order to save and read LDAP Protocol requests/responses sent/received in
> the proxy, an XML Parser/Writer should be implemented using Dom4J.
> Here's a sample XML Parser/Writer implementation for connections in the
> 'connection.core' plugin:
> http://svn.apache.org/repos/asf/directory/studio/tags/1.5.3.v20100330/connection-core/src/main/java/org/apache/directory/studio/connection/core/io/ConnectionIO.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
