[ 
https://issues.apache.org/jira/browse/DIRSERVER-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908989#action_12908989
 ] 

Stefan Seelmann commented on DIRSERVER-1541:
--------------------------------------------

I checked the Javadoc at 
http://download.oracle.com/javase/6/docs/api/java/util/regex/Pattern.html and I 
don't see a thread safety problem here. The Pattern instance itself is thread 
safe, including the creation of the Matcher. And as a new Matcher is created 
every time there should be no problem. Thoughts?


> Numerous JUnit tests failing on Windows.
> ----------------------------------------
>
>                 Key: DIRSERVER-1541
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1541
>             Project: Directory ApacheDS
>          Issue Type: Bug
>          Components: core, ldap, schema
>    Affects Versions: 2.0.0-RC1
>         Environment: All Microsoft Windows.
>            Reporter: Richard M Feezel
>            Assignee: Emmanuel Lecharny
>            Priority: Minor
>             Fix For: 2.0.0-RC1
>
>         Attachments: ADS_Patches.diff.txt, WindowsPatches.diff
>
>
> File names and paths are not being handled in a platform-independent manner 
> is all cases.
> In particular, in regex matching patterns the "\" has special meaning.  On 
> Windows the "\" is used as the file directory separator character so a regex 
> attempting to test for a directory separator character must be constructed in 
> a platform-dependent manner.
> Also, certain characters are not allowed in file names in Microsoft Windows.  
> Any attempt to use such names must have these special characters "escaped" to 
> safe characters.  Since the "\" character is the directory separator 
> character it is unsuitable for special character escaping.
> Finally, in the JdbmStoreTest test, stores and indexes must be destroyed 
> and/or closed to permit deletion of the underlying files at completion of the 
> test run.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to