Review Request: ApacheDsService.start() method refactoring

[Emmanuel Lécharny]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14/
-----------------------------------------------------------

Review request for directory.


Summary
-------

I have modified the ApacheDsService start method this way :

    public void start( InstanceLayout instanceLayout ) throws Exception
    {
        File partitionsDir = instanceLayout.getPartitionsDirectory();
        
        if ( !partitionsDir.exists() )
        {
            LOG.info( "partition directory doesn't exist, creating {}", 
partitionsDir.getAbsolutePath() );
            partitionsDir.mkdirs();
        }

        LOG.info( "using partition dir {}", partitionsDir.getAbsolutePath() );
        
        initSchemaLdifPartition( instanceLayout );
        initConfigPartition( instanceLayout );

        // Read the configuration
        cpReader = new ConfigPartitionReader( configPartition, partitionsDir );
        
        ConfigBean configBean = cpReader.readConfig( "ou=config" );
        
        DirectoryServiceBean directoryServiceBean = 
configBean.getDirectoryServiceBean( "default" );
        
        // Initialize the DirectoryService now
        DirectoryService directoryService = initDirectoryService( 
instanceLayout, directoryServiceBean );

        // start the LDAP server
        startLdap( directoryServiceBean.getLdapServerBean(), directoryService );

        // start the NTP server
        startNtp( directoryServiceBean.getNtpServerBean(), directoryService );

        // Initialize the DNS server (Not ready yet)
        // initDns( configBean );

        // Initialize the DHCP server (Not ready yet)
        // initDhcp( configBean );

        // start the ChangePwd server (Not ready yet)
        startChangePwd( directoryServiceBean.getChangePasswordServerBean(), 
directoryService );

        // start the Kerberos server
        startKerberos( directoryServiceBean.getKdcServerBean(), 
directoryService );

        // start the jetty http server
        startHttpServer( directoryServiceBean.getHttpServerBean(), 
directoryService );
    }


Diffs
-----


Diff: https://reviews.apache.org/r/14/diff


Testing
-------


Thanks,

Emmanuel