@Stefan

Feel free to revert my latest 2 commits [1] on the pom.xml for re-releasing. I didn't thought that the release will be rolled back ...

Sorry
Felix

[1] http://svn.apache.org/viewvc?rev=1065674&view=rev
    http://svn.apache.org/viewvc?rev=1065667&view=rev

On 01/31/2011 07:59 PM, Stefan Seelmann wrote:
Thanks Pierre-Arnaud for the info.

Then I'm going to drop the current staging repository and rollback the
release in SVN, remove that plugin configuration, and release again.

Kind Regards,
Stefan


On Mon, Jan 31, 2011 at 5:30 PM, Pierre-Arnaud Marcelot<[email protected]>  
wrote:
Ooops,

Sorry about that.

Indeed, I added this to be able to import the 'project' project in Eclipse.

Obviously I wasn't thinking about the fact that it would be inherited by all 
our projects modules.

I guess we can get rid of this and find another way to import the project in 
Eclipse without messing around all other projects modules.
That's not something we do very often.

Regards,
Pierre-Arnaud

On 31 janv. 2011, at 17:20, Stefan Seelmann wrote:

This was added by Pierre-Arnaud:
http://svn.apache.org/viewvc?view=revision&revision=1062885

So yes, I think it was added to generate the Eclipse project files,
useful for people that don't use m2eclipse (like me) ;-)

Kind Regards,
Stefan


On Mon, Jan 31, 2011 at 4:18 PM, Felix Knecht<[email protected]>  wrote:
Not sure if we even need this in the TLP pom. IMO it's only used when
running maven-eclipse-plugin to generate an Eclipse .project/.classpath for
importing into Eclipse. This can also be done when importing the project via
Eclipse' m2e [3] plugin ->  in Eclipse import as existing Maven project.
So the only place where it may be needed is in the studio project (if this
can't be imported as Maven Project into Eclipse via Eclipse' m2e.

So if really needed it could just put into the studio/pom.xml and dropped
from the TLP pom.

Maybe I'm missing something else?

Regards
Felix

[3] http://m2eclipse.sonatype.org/

On 01/31/2011 04:06 PM, Stefan Seelmann wrote:

I just found an issue:

The new project/pom.xml configures and runs the maven-eclipse.plugin:
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-eclipse-plugin</artifactId>
         <configuration>
           <skip>false</skip>
           <pde>true</pde>
           <!-- Workaround for http://jira.codehaus.org/browse/MECLIPSE-94
-->
           <eclipseProjectDir>..</eclipseProjectDir>
           <!-- We don't want any sources or javadocs jars -->
           <downloadSources>false</downloadSources>
           <downloadJavadocs>false</downloadJavadocs>
         </configuration>
       </plugin>


This configuration in inherited by the sub-projects. It is required to
overwrite the configuration in each sub-project to fix the generation
of Eclipse project files.

I added the following for shared/pom.xml, the same must be added to
the other sub-projects:
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-eclipse-plugin</artifactId>
         <configuration>
           <pde>false</pde>
           <eclipseProjectDir>${eclipse.projectDir}</eclipseProjectDir>
           <downloadSources>true</downloadSources>
           <downloadJavadocs>true</downloadJavadocs>
         </configuration>
       </plugin>


Is this acceptable, or is there a way to prevent configuration
inheritance?

Kind Regards,
Stefan



On Mon, Jan 31, 2011 at 2:42 PM, Stefan Seelmann<[email protected]>
  wrote:

Hi devs,

I'd like to release a new TLP pom (version 19).

Changes:
- Full Maven 3 support, including site generation
- Dropped Maven 2 support
- Updated plugin versions
- Removed outdated mailing list archives

The tagged pom can be found at [1], the staging repository can be found
at [2].

I'll continue to release the staging repository after the grace period
of 4 hours.

Kind Regards,
Stefan


[1] https://svn.apache.org/repos/asf/directory/project/tags/19/
[2]
https://repository.apache.org/content/repositories/orgapachedirectory-018/








Reply via email to