Sounds good to me. Regards, Pierre-Arnaud
On 8 févr. 2011, at 10:32, Stefan Seelmann wrote: > On Tue, Feb 8, 2011 at 9:20 AM, Stefan Seelmann <[email protected]> wrote: >> I found something over at stackoverflow to define different compile >> versions for main and test code [4], I'll test that. > > Obviously that won't work because JDK5 doesn't have a Java6 compiler. > > So what I would suggest is to copy the classes from [5] with the > original package names and license/copyright headers to our > junit-addons module. As the classes have the ALv2 license header we > are safe to copy them. An advantage is that once we switch to Java6 we > can drop those classes and use the com.mycila:mycila-junit dependency. > > Thoughts? > > Kind Regards, > Stefan > > [5] > http://code.google.com/p/mycila/source/browse/mycila-junit/tags/mycila-junit-1.0.ga/src/main/java/com/mycila/junit/concurrent > > >> [4] >> http://stackoverflow.com/questions/1213897/different-maven-compiler-versions-for-test-and-main >> >> On Tue, Feb 8, 2011 at 9:14 AM, Pierre-Arnaud Marcelot <[email protected]> >> wrote: >>> Hi Stefan, >>> >>> How deep is this used in ApacheDS? >>> Is it only to have JUnit tests run in multithreaded mode? >>> Would this also impact the ApacheDS distributions and prevent them from >>> running on Java 5? >>> >>> Thanks, >>> Pierre-Arnaud >>> >>> On 8 févr. 2011, at 09:06, Stefan Seelmann wrote: >>> >>>> Seems I was a bit too fast. The com.mycila:mycila-junit jar is >>>> compiled with Java6, thus our Java5 builds fail. >>>> >>>> Our options: >>>> (a) switch to Java6 >>>> (b) revert my change >>>> (c) fork com.mycila:mycila-junit and build it with Java5 >>>> >>>> Kind Regards, >>>> Stefan >>>> >>>> >>>> On Mon, Feb 7, 2011 at 10:20 PM, Stefan Seelmann <[email protected]> >>>> wrote: >>>>> Done: http://svn.apache.org/viewvc?rev=1068139&view=rev >>>>> >>>>> On Mon, Feb 7, 2011 at 8:12 PM, Stefan Seelmann <[email protected]> >>>>> wrote: >>>>>> Hi devs, >>>>>> >>>>>> we have an outstanding minor legal issue with junit-addons [1]. >>>>>> >>>>>> Fortunately Mathieu Carbou released an official version of his JUnit >>>>>> code [2] under ALv2, available in Maven Central [3]. >>>>>> >>>>>> I'll try to use that artifact as test dependency instead of the copied >>>>>> classes, maybe we can get rid of them. >>>>>> >>>>>> Kind Regards, >>>>>> Stefan >>>>>> >>>>>> >>>>>> [1] http://markmail.org/message/ofmtcs3mirvjn2hf >>>>>> [2] >>>>>> http://code.google.com/p/mycila/source/browse/mycila-junit/tags/mycila-junit-1.0.ga >>>>>> [3] http://repo2.maven.org/maven2/com/mycila/mycila-junit/1.0.ga/ >>>>>> >>>>> >>> >>> >>
