On 2/15/11 11:30 PM, Alex Karasulu wrote:
On Tue, Feb 15, 2011 at 5:00 PM, Emmanuel Lecharny<[email protected]>wrote:

Hi again,

going a bit deeper, I'm wondering if the Dn class should implement the
Cloneable and Serializable interfaces?

Cloneable is probably not needed, as the Dn is immutable, and Serializable
is also useless, as we already have a DnSerializer helper class that handles
the Dn serialization. Note that we have a DnFactory class in the server
which expect the Dn class to be serializable, but this is probably not
needed, as we never serialize the associated cache to disk.

thoughts ?


I agree. However maybe there was some reason why it was made serializable
for replication needs however this can be handled with the string
representation.
Not anymore. We have the DnSerializer for that, and it's already used (except the few places I just fixed).


--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

Reply via email to