Hi Emmanuel, Doco looks fine to me.
I think the naming of two methods could be improved for readability and coherence with standard Java and our own coding standards: - boolean isHR(); ---> boolean isHumanReadable(); - boolean instanceOf( AttributeType attributeType ); ---> boolean isInstanceOf( AttributeType attributeType ); Very minor concerns... Regards, Pierre-Arnaud On 30 mars 2011, at 02:16, Emmanuel Lecharny wrote: > https://cwiki.apache.org/confluence/display/DIRAPI/Value > > For review... > > -- > Regards, > Cordialement, > Emmanuel Lécharny > www.iktek.com >
