On Thu, Apr 28, 2011 at 9:30 PM, Stefan Seelmann <[email protected]> wrote: > On Thu, Apr 28, 2011 at 5:39 PM, Emmanuel Lecharny <[email protected]> > wrote: >> I like Stefan's idea a lot, but there is something a bit confusing : if a >> user tries to do a simple search, he will expect the LdapConnection.search() >> to be the method to use. Having to use LdapConnection.searchEntries() >> instead is a bit problematic. >> >> What about transforming the LdapConnection.search( SearchRequest ) method to >> LdapConnection.send( SearchRequest ) (and the very same for any complex >> request, using a Request instance) : >> - LdapConnection.send( AddRequest ) but LdapConnection.add( Entry ) >> - LdapConnection.send( BindRequest ) but LdapConnection.bind( dn, password ) >> - LdapConnection.send( SearchRequest ) but Cursor<Entry> >> LdapConnection.search( base, filter, scope, attrs...) >> - ... >> >> thoughts ? > > Sure, that makes totally sense because the operation is already part > of the request class. And fortunately "search" will be listed before > "send" in the API docs and code completion popup window ;-) > I agree with all the other changes except for using send() as the name for all operation methods, I say this as an end user rather than a programmer of this API > Kind Regards, > Stefan >
-- Kiran Ayyagari
