On 6/22/11 1:58 PM, Kiran Ayyagari wrote:
On Wed, Jun 22, 2011 at 5:02 PM,<[email protected]>  wrote:
Author: elecharny
Date: Wed Jun 22 11:32:15 2011
New Revision: 1138408

URL: http://svn.apache.org/viewvc?rev=1138408&view=rev
Log:
Minor refactoring and improvement

Modified:
    
directory/apacheds/trunk/core/src/main/java/org/apache/directory/server/core/DefaultDirectoryService.java
    
directory/apacheds/trunk/jdbm-partition/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmStore.java
    
directory/apacheds/trunk/xdbm-partition/src/main/java/org/apache/directory/server/xdbm/impl/avl/AvlStore.java

Modified: 
directory/apacheds/trunk/core/src/main/java/org/apache/directory/server/core/DefaultDirectoryService.java
URL: 
http://svn.apache.org/viewvc/directory/apacheds/trunk/core/src/main/java/org/apache/directory/server/core/DefaultDirectoryService.java?rev=1138408&r1=1138407&r2=1138408&view=diff
==============================================================================
--- 
directory/apacheds/trunk/core/src/main/java/org/apache/directory/server/core/DefaultDirectoryService.java
 (original)
+++ 
directory/apacheds/trunk/core/src/main/java/org/apache/directory/server/core/DefaultDirectoryService.java
 Wed Jun 22 11:32:15 2011
@@ -989,12 +989,12 @@ public class DefaultDirectoryService imp
         // load the last stored valid CSN value
         LookupOperationContext loc = new LookupOperationContext( 
getAdminSession() );
         loc.setDn( systemPartition.getSuffix() );
-        loc.setAttrsId( new String[]{ "+" } );
+        loc.setAttrsId( new String[]{ SchemaConstants.CONTEXT_CSN_AT } );
actually changing it to loc.setAttrsId( new String[]{ "*", "+" } );
will make it faster, the BaseEntryFilteringCursor's filterContents()
returns immediately.

P.S:- in this case we might be targeting readability, but just thought
of pointing it.

Yes, that's true, but it's not a critical part, so I'd rather favor readability in this very case...


--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

Reply via email to