[ 
https://issues.apache.org/jira/browse/DIRSERVER-1672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131567#comment-13131567
 ] 

Pierre-Arnaud Marcelot commented on DIRSERVER-1672:
---------------------------------------------------

Hi Göktürk,

I imported the patch.

However I'm getting the following test failures, did you have the same too?

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running 
org.apache.directory.shared.ldap.schemaextractor.impl.SchemaLdifExtractorTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.113 sec
Running org.apache.directory.shared.ldap.schemaloader.JarLdifSchemaLoaderTest
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.295 sec <<< 
FAILURE!
Running org.apache.directory.shared.ldap.schemaloader.LdifSchemaLoaderTest
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.528 sec <<< 
FAILURE!
Running org.apache.directory.shared.ldap.schemaloader.MatchingRuleTest
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.993 sec <<< 
FAILURE!
Running org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest
Tests run: 58, Failures: 0, Errors: 57, Skipped: 0, Time elapsed: 2.555 sec <<< 
FAILURE!
Running org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest
Tests run: 30, Failures: 0, Errors: 30, Skipped: 0, Time elapsed: 1.813 sec <<< 
FAILURE!
Running 
org.apache.directory.shared.ldap.schemaloader.SchemaManagerEnableDisableLoadTest
Tests run: 7, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 1.243 sec <<< 
FAILURE!
Running org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadTest
Tests run: 19, Failures: 0, Errors: 15, Skipped: 2, Time elapsed: 1.904 sec <<< 
FAILURE!
Running 
org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadWithDepsTest
Tests run: 14, Failures: 0, Errors: 13, Skipped: 0, Time elapsed: 1.526 sec <<< 
FAILURE!

Results :

Tests in error: 
  
testJarLdifSchemaLoader(org.apache.directory.shared.ldap.schemaloader.JarLdifSchemaLoaderTest):
 Required Comparator is not registered
  
testLoader(org.apache.directory.shared.ldap.schemaloader.LdifSchemaLoaderTest): 
Required Comparator is not registered
  org.apache.directory.shared.ldap.schemaloader.MatchingRuleTest: Required 
Comparator is not registered
  
testAddAttributeTypeNoSupCollectiveUser(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAttributeTypeNoSupNoSyntaxNoSuperior(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAttributeTypeSupCollectiveUser(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAttributeTypeNoSupCollectiveOperational(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAlreadyExistingNormalizer(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddValidMatchingRule(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAttributeTypeNoSupInvalidOrderingMR(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAttributeTypeNoSupNoUserModificationUserAplication(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAttributeTypeNoSupInvalidSubstringMR(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAttributeTypeNoEqualityMR(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAlreadyExistingComparator(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddMatchingRuleExistingName(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAttributeTypeNameOfAnObjectClass(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAttributeTypeSupNoSyntaxNoSuperior(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddMatchingRuleNotExistingSyntax(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAttributeTypeSupBadSup(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAttributeTypeNoSupInvalidEqualityMR(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAttributeTypeNoSupNoUserModificationOpAttr(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAttributeTypeSupWithOwnSup(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAttributeTypeSupDifferentUsage(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassSuperiorsStructuralWithAuxiliaryInSup(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddNewNormalizer(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassSuperiorsWithCycle(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddMatchingRuleExistingOID(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAttributeTypeNoSupValidMR(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAttributeTypeAlreadyExist(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddMatchingRuleNotExistingSchema(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassSuperiorsAuxiliaryWithStructuralInSup(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddSyntaxExistingOid(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddNewSyntaxChecker(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassNoSuperiorATMoreThanOnceInMay(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassNoSuperiorCollectiveATInMustOrMay(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassNoSuperiorATMoreThanOnceInMust(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassSuperiorsNonExistingOCInSup(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassNoSuperiorNonExistingAtInMay(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddNewComparator(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassSuperiorsOcMoreThanOnceInSup(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassNoSuperiorATInMustAndMay(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAttributeTypeNameAlreadyExist(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddMatchingRuleExistingATName(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassNoSuperiorNonExistingAtInMust(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassSuperiorsValid(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddNormalizerWithWrongFQCN(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddMatchingRuleNoSyntax(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAttributeTypeCollectiveOperationalSigleValue(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassNoSuperiorWithATName(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassNoSuperiorWithExistingOCName(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddAlreadyExistingSyntaxChecker(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassSuperiorsATInMustPresentInSuperiorsMay(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassNoSuperiorValid(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassNoSuperiorWithExistingOid(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddComparatorWithWrongFQCN(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddValidSyntax(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassSuperiorsATInMayPresentInSuperiorsMust(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassSuperiorsAbstractWithAuxiliaryInSup(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddSyntaxCheckerWithWrongFQCN(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testAddObjectClassSuperiorsAbstractWithStructuralInSup(org.apache.directory.shared.ldap.schemaloader.SchemaManagerAddTest):
 Required Comparator is not registered
  
testDeleteExistingAttributeTypeUsedByOC(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingAttributeType(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteNonExistingAttributeType(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDelAttributeTypeFromDisabledSchema(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingAttributeTypeUsedByDescendant(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingComparator(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteNonExistingComparator(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingComaparatorUsedByMatchingRule(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingComparatorUsedByRemovedMatchingRule(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteNonExistingMatchingRule(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingSyntaxUsedByAttributeType(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingMatchingRuleUsedByAttributeType(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingMatchingRuleUsedByRemovedAttributeType(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingNormalizer(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteNonExistingNormalizer(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingNormalizerUsedByMatchingRule(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingNormalizerUsedByRemovedMatchingRule(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingObjectClass(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteNonExistingObjectClass(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingSyntaxCheckerUsedBySyntax(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingSyntax(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteNonExistingSyntaxChecker(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingSyntaxChecker(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingSyntaxUsedByRemovedAttributeType(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingSyntaxUsedByMatchingRule(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingSyntaxCheckerUsedByRemovedSyntax(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingMatchingRule(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteNonExistingSyntax(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingObjectClassUsedByAnotherObjectClass(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testDeleteExistingSyntaxUsedByRemovedMatchingRule(org.apache.directory.shared.ldap.schemaloader.SchemaManagerDelTest):
 Required Comparator is not registered
  
testLoadAllEnabled(org.apache.directory.shared.ldap.schemaloader.SchemaManagerEnableDisableLoadTest):
 Required Comparator is not registered
  
testEnableDisabled(org.apache.directory.shared.ldap.schemaloader.SchemaManagerEnableDisableLoadTest):
 Required Comparator is not registered
  
testEnableAlreadyEnabled(org.apache.directory.shared.ldap.schemaloader.SchemaManagerEnableDisableLoadTest):
 Required Comparator is not registered
  
testDisableEnabled(org.apache.directory.shared.ldap.schemaloader.SchemaManagerEnableDisableLoadTest):
 Required Comparator is not registered
  
testEnableDisabledDependingOnDisabled(org.apache.directory.shared.ldap.schemaloader.SchemaManagerEnableDisableLoadTest):
 Required Comparator is not registered
  
testLoadSystem(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadTest):
 Required Comparator is not registered
  
testLoadCore(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadTest):
 Required Comparator is not registered
  
testLoadApache(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadTest):
 Required Comparator is not registered
  
testLoadApacheMeta(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadTest):
 Required Comparator is not registered
  
testLoadJava(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadTest):
 Required Comparator is not registered
  
testLoadOther(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadTest):
 Required Comparator is not registered
  
testLoadCosine(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadTest):
 Required Comparator is not registered
  
testLoadInetOrgPerson(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadTest):
 Required Comparator is not registered
  
testLoadCollective(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadTest):
 Required Comparator is not registered
  
testLoadKrb5Kdc(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadTest):
 Required Comparator is not registered
  
testLoadNis(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadTest):
 Required Comparator is not registered
  
testLoadWrongSchema(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadTest):
 Required Comparator is not registered
  
testLoadCoreAndInetOrgPerson(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadTest):
 Required Comparator is not registered
  
testLoadCoreInetOrgPersonAndBad(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadTest):
 Required Comparator is not registered
  
testLoadSchemasWithDepsCoreInetOrgPersonAndBad(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadTest):
 Required Comparator is not registered
  
testLoadSystem(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadWithDepsTest):
 Required Comparator is not registered
  
testLoadCore(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadWithDepsTest):
 Required Comparator is not registered
  
testLoadApache(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadWithDepsTest):
 Required Comparator is not registered
  
testLoadJava(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadWithDepsTest):
 Required Comparator is not registered
  
testLoadApacheMeta(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadWithDepsTest):
 Required Comparator is not registered
  
testLoadCosine(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadWithDepsTest):
 Required Comparator is not registered
  
testLoadInetOrgPerson(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadWithDepsTest):
 Required Comparator is not registered
  
testLoadCollective(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadWithDepsTest):
 Required Comparator is not registered
  
testLoadOther(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadWithDepsTest):
 Required Comparator is not registered
  
testLoadKrb5Kdc(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadWithDepsTest):
 Required Comparator is not registered
  
testLoadCoreAndInetOrgPerson(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadWithDepsTest):
 Required Comparator is not registered
  
testLoadCoreInetOrgPersonAndNis(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadWithDepsTest):
 Required Comparator is not registered
  
testLoadWithDepsCoreInetOrgPersonAndNis(org.apache.directory.shared.ldap.schemaloader.SchemaManagerLoadWithDepsTest):
 Required Comparator is not registered

Tests run: 132, Failures: 0, Errors: 123, Skipped: 2

                
> Making Comparators extendable
> -----------------------------
>
>                 Key: DIRSERVER-1672
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1672
>             Project: Directory ApacheDS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-M4
>            Reporter: Göktürk Gezer
>              Labels: apacheds, osgi, shared
>             Fix For: 2.0.0-M4
>
>         Attachments: comparator_management.diff
>
>
> To provide 3th parties an ability to write their own schema elements, the 
> first part is making LdapComparators pluggable to shared-ldap-model. And 
> existing clients must be preserved as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to