On 10/28/11 9:46 AM, Selcuk AYA wrote:
On Thu, Oct 27, 2011 at 12:24 PM,<[email protected]>  wrote:
Author: elecharny
Date: Thu Oct 27 09:24:23 2011
New Revision: 1189688

URL: http://svn.apache.org/viewvc?rev=1189688&view=rev
Log:
o Added a Log.begingScan() method with no argument
log files are deleted as minneeded log file is advances. So this
method should get a consistent copy of the min needed log file or min
existing log file and should start scanning from there.

yeah, I realized that this afternoon as I was working on the code. Should I fix the method ?

o Renamed LogScanner to LogScannerInternal
o Made fields private
I think it is unnecessary to make internal private class fields
private. As I mentioned before, I use these little inner classes to
group data together and I access them directly.

This is just a protection. Later, if you make this inner class a plain class, you will have to make the field private.


--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

Reply via email to