There seems to be a lot of refactorings taking place as things are advancing. Perhaps the refactoring can be left until some check point where the code is almost complete and at least there is good code coverage. This way such errors with refactoring can be caught by the tests.
On Thu, Oct 27, 2011 at 5:52 PM, Emmanuel Lecharny <[email protected]>wrote: > On 10/27/11 4:39 PM, [email protected] wrote: > >> Author: saya >> Date: Thu Oct 27 14:39:22 2011 >> New Revision: 1189785 >> >> URL: >> http://svn.apache.org/viewvc?**rev=1189785&view=rev<http://svn.apache.org/viewvc?rev=1189785&view=rev> >> Log: >> last successful file offset should be advanced only after successful >> reads. Reverted the change introduced during code cleanups. >> > > Sorry, I don't even remember why I moved this line... Stupid change. > > -- > Regards, > Cordialement, > Emmanuel Lécharny > www.iktek.com > > -- Best Regards, -- Alex
