Great job guys! Sent from my iPhone
On Nov 4, 2011, at 5:59 PM, Emmanuel Lecharny <[email protected]> wrote: > Hi guys, > > thanks to Kiran, who did a lot of cleanup yesterday, we have been able to > remove a lot of bypasses in the code. > > We still have a few remaining operations using bypasses : > > * In AuthenticationInterceptor.bind(), modify operation : > { NormalizationInterceptor, > AuthenticationInterceptor, > AciAuthorizationInterceptor, > AdministrativePointInterceptor, > DefaultAuthorizationInterceptor, > AdministrativePointInterceptor, > ExceptionInterceptor, > OperationalAttributeInterceptor, > SchemaInterceptor, > CollectiveAttributeInterceptor, > SubentryInterceptor, > EventInterceptor, > TriggerInterceptor } > > * in MaxImmSubFilter.getImmSubCount, search operation: > { NormalizationInterceptor > AuthenticationInterceptor > AciAuthorizationInterceptor > DefaultAuthorizationInterceptor > AdministrativePointInterceptor > OperationalAttributeInterceptor > SchemaInterceptor > SubentryInterceptor > EventInterceptor } > > * in SchemaSubentryModifier.[add, addSchemaObject, deleteSchemaObject, > delete], add, delete operations : > { AuthenticationInterceptor, > AciAuthorizationInterceptor, > DefaultAuthorizationInterceptor, > ExceptionInterceptor, > SchemaInterceptor } > > add() with bypass : > ================= > in SchemaSubentryModifier.add : > { AuthenticationInterceptor, > AciAuthorizationInterceptor, > DefaultAuthorizationInterceptor, > ExceptionInterceptor, > SchemaInterceptor } > > > delete() with bypass : > ==================== > in SchemaSubentryModifier.delete : > { AuthenticationInterceptor, > AciAuthorizationInterceptor, > DefaultAuthorizationInterceptor, > ExceptionInterceptor, > SchemaInterceptor } > > > > lookup() with bypass : > ==================== > in CollectiveAttributeInterceptor.addCollectiveAttributes, > ByPassConstants.LOOKUP_COLLECTIVE_BYPASS > > modify() with bypass : > ==================== > in SchemaPartition.updateSchemaModificationAttributes, > ByPassConstants.SCHEMA_MODIFICATION_ATTRIBUTES_UPDATE_BYPASS > > > We can probably remove some of them, but this is not guaranteed to work. > > What we are going to do now is : > - check if the exception interceptors is still mandatory > - create some special method instead of using bypasses in an interface > > Thi will be done in the OSGi branch. > > FYI, I have merged back the osgi branch modifications relative to bypass > cleanup into trunks. > > -- > Regards, > Cordialement, > Emmanuel Lécharny > www.iktek.com >
