[ 
https://issues.apache.org/jira/browse/DIRSHARED-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486992#comment-13486992
 ] 

Hendy Irawan commented on DIRSHARED-142:
----------------------------------------

The StringValue.equals() check is correct because :

        // First check the upValue. If they are equal, the Values are equal
        if ( wrappedValue == other.wrappedValue )            // returns true 
here
        {
            return true;
        }

and the attributeType check is still below that code....
                
> Value<?> objects containing byte[] of same content should be equals() == true
> -----------------------------------------------------------------------------
>
>                 Key: DIRSHARED-142
>                 URL: https://issues.apache.org/jira/browse/DIRSHARED-142
>             Project: Directory Shared
>          Issue Type: Bug
>    Affects Versions: 1.0.0-M13
>            Reporter: Hendy Irawan
>
> 1. get two Attribute objects from different sources, e.g. from LDAP 
> connection vs. by creating an entry programmatically
> 2. attribute1.get().equals( attribute2.get() ) will return false, which is 
> wrong, because :
> Arrays.equals((byte[])attribute1.get().getNormValue(), (byte[]) 
> attribute2.get().getNormValue())
> will return true in this case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to