[
https://issues.apache.org/jira/browse/DIRAPI-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498938#comment-13498938
]
Damien Dubé commented on DIRAPI-96:
-----------------------------------
I would think that the Exception that I would like to have is the bind
exception. But it is true that if the close fails, I probably want this one.
Hopefully this won't happen much!
> Connection leak in LdapConnectionPool.
> --------------------------------------
>
> Key: DIRAPI-96
> URL: https://issues.apache.org/jira/browse/DIRAPI-96
> Project: Directory Client API
> Issue Type: Bug
> Reporter: Damien Dubé
> Fix For: 1.0.0-M13
>
>
> If a Connection fails on credentials, the LdapConnection is not closed and is
> not in the pool.
> I modified the makeObject() function in PoolableLdapConnectionFactory.java to
> this and it does the trick.
> public Object makeObject() throws Exception
> {
> LOG.debug("creating a LDAP connection");
> LdapNetworkConnection connection = new LdapNetworkConnection(config);
> try {
> connection.bind(config.getName(), config.getCredentials());
> } catch (Exception e1) {
> try {
> connection.close();
> } catch (Exception e2) {
> }
> throw e1;
> }
> return connection;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
