[ 
https://issues.apache.org/jira/browse/DIRSERVER-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kiran Ayyagari resolved DIRSERVER-1920.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0-M16
         Assignee: Kiran Ayyagari

Thanks for taking time to create a patch, I have not applied the suggested
changes for service factory, cause it is calling instance methods inside
the constructor, instead added a new constructor that takes instances of
DirectoryService and PartitionFactory.

Changed the scope of showSecurityWarnings() to protected.

Committed here http://svn.apache.org/r1546144


> Refactor DefaultDirectoryServiceFactory/DefaultDirectoryService for 
> extensability
> ---------------------------------------------------------------------------------
>
>                 Key: DIRSERVER-1920
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1920
>             Project: Directory ApacheDS
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 2.0.0-M15
>            Reporter: Kevin Minder
>            Assignee: Kiran Ayyagari
>             Fix For: 2.0.0-M16
>
>         Attachments: 
> DIRSERVER_1920__Refactor_DefaultDirectoryServiceFactory_DefaultDirectoryService_for_extensability.patch
>
>
> Enhance the extensibility and reusability of 
> apacheds/apacheds/core-annotations/src/main/java/org/apache/directory/server/core/factory/DefaultDirectoryServiceFactory.java
> apacheds/apacheds/core/src/main/java/org/apache/directory/server/core/DefaultDirectoryService.java
> For DefaultDirectoryServiceFactory create overridable methods for the 
> creation of the DirectoryService and PartitionFactory.
> For DefaultDirectoryService make showSecuirtyWarnings to allow control for 
> that behavior in subclasses.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to