[ 
https://issues.apache.org/jira/browse/DIRSTUDIO-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142522#comment-14142522
 ] 

Emmanuel Lecharny commented on DIRSTUDIO-995:
---------------------------------------------

Looking at common.ui, I see that many packages which are in java source files 
imports aren't present in the MANIFEST.MF file. for instance, here is the list 
of all imported packages we have :

{code}
import org.eclipse.core.runtime
import org.eclipse.jface.action
import org.eclipse.jface.dialogs
import org.eclipse.jface.preference
import org.eclipse.jface.resource
import org.eclipse.swt
import org.eclipse.swt.custom
import org.eclipse.swt.events
import org.eclipse.swt.graphics
import org.eclipse.swt.layout
import org.eclipse.swt.widgets
import org.eclipse.ui
import org.eclipse.ui.editors.text
import org.eclipse.ui.plugin
import org.osgi.framework
{code}

I was expecting to find this list present in the MANIFEST.MF, but here is what 
we have :

{code}
Require-Bundle: org.eclipse.core.runtime,
 org.eclipse.ui,
 org.eclipse.ui.editors
{code}

Shouldn't we complete this short list with the imports we find in the java 
files, to have something like :

{code}
Require-Bundle: org.eclipse.core.runtime,
 org.eclipse.jface.action,
 org.eclipse.jface.dialogs,
 org.eclipse.jface.preference,
 org.eclipse.jface.resource,
 org.eclipse.swt,
 org.eclipse.swt.custom,
 org.eclipse.swt.events,
 org.eclipse.swt.graphics,
 org.eclipse.swt.layout,
 org.eclipse.swt.widgets,
 org.eclipse.ui,
 org.eclipse.ui.editors.text,
 org.eclipse.ui.plugin,
 org.osgi.framework
{code}



> Migrate build system to use Tycho
> ---------------------------------
>
>                 Key: DIRSTUDIO-995
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-995
>             Project: Directory Studio
>          Issue Type: Task
>    Affects Versions: 2.0.0-M8 (2.0.0.v20130628)
>            Reporter: Stefan Seelmann
>            Assignee: Stefan Seelmann
>            Priority: Blocker
>             Fix For: 2.0.0-M9
>
>
> Just a TODO list for now...
> * Manage 3rd party dependencies
> * Move tests to *.test fragments?
> * Use Luna
> * Migrate plugins
> ** Done:common,core, common.ui, connection.core, connection.ui, ldifparser, 
> ldifeditor, ldapbrowser.core, ldapbrowser.common, ldapbrowser.ui
> ** In progess: 
> * Migrate features
> ** Done: 
> ** In progress: ldifeditor, ldapbrowser
> * Migrate RCP application
> * Migrate help plugins
> * Installers (Windows EXE, Mac DMG)
> * Generate P2 repository / site, self-hosted
> * P2 repository for API and ApacheDS bundles?
> * Migrate release process
> * Document build system
> * Cleanup POMs: RAT plugin configuration
> * Cleanup old "repository" folder
> Tycho Pros:
> * Easy to consume Eclipse dependencies from p2 repo
> * Easy to produce p2 repo
> * Widely used
> * Small POMs
> Tycho Cons:
> * Managing versions in MANIFEST.MF
> * 3rd party dependencies not available in any p2 repo
> * No "Standard" Maven build, e.g. tests should reside in separate modules



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to