Hi Emmanuel, I removed it for now because Eclipse complained about the version "2.4" of commons.io, the right OSGi version would be 2.4.0. Also for Import-Package it must be named "version", not "bundle-version" (in valueeditor). As far as I understand that named version is the minimum version, not a fixed version. But I agree that a version makes sense, I'd add them later when migration is done and all works fine.
Kind Regards, Stefan On 10/26/2014 08:58 PM, Emmanuel Lécharny wrote: > I stefan, > > I have a question : why is it necessary to remove the version from the > import package? Isn't it better to enforce the use of a specific version > ? (just wondering...) > > > > Le 26/10/14 20:05, [email protected] a écrit : >> Author: seelmann >> Date: Sun Oct 26 19:05:52 2014 >> New Revision: 1634381 >> >> URL: http://svn.apache.org/r1634381 >> Log: >> Add missing activator and localization. remove versions from import package >> >> Modified: >> >> directory/studio/branches/studio-tycho/plugins/aciitemeditor/META-INF/MANIFEST.MF >> >> directory/studio/branches/studio-tycho/plugins/schemaeditor/META-INF/MANIFEST.MF >> >> directory/studio/branches/studio-tycho/plugins/valueeditors/META-INF/MANIFEST.MF >> >> Modified: >> directory/studio/branches/studio-tycho/plugins/aciitemeditor/META-INF/MANIFEST.MF >> URL: >> http://svn.apache.org/viewvc/directory/studio/branches/studio-tycho/plugins/aciitemeditor/META-INF/MANIFEST.MF?rev=1634381&r1=1634380&r2=1634381&view=diff >> ============================================================================== >> --- >> directory/studio/branches/studio-tycho/plugins/aciitemeditor/META-INF/MANIFEST.MF >> (original) >> +++ >> directory/studio/branches/studio-tycho/plugins/aciitemeditor/META-INF/MANIFEST.MF >> Sun Oct 26 19:05:52 2014 >> @@ -6,6 +6,8 @@ Bundle-Version: 2.0.0.qualifier >> Bundle-SymbolicName: >> org.apache.directory.studio.aciitemeditor;singleton:=true >> Bundle-License: http://www.apache.org/licenses/LICENSE-2.0.txt >> Bundle-RequiredExecutionEnvironment: JavaSE-1.6 >> +Bundle-Localization: plugin >> +Bundle-Activator: org.apache.directory.studio.aciitemeditor.Activator >> Eclipse-LazyStart: true >> Export-Package: org.apache.directory.studio.aciitemeditor >> Require-Bundle: org.eclipse.core.runtime, >> >> Modified: >> directory/studio/branches/studio-tycho/plugins/schemaeditor/META-INF/MANIFEST.MF >> URL: >> http://svn.apache.org/viewvc/directory/studio/branches/studio-tycho/plugins/schemaeditor/META-INF/MANIFEST.MF?rev=1634381&r1=1634380&r2=1634381&view=diff >> ============================================================================== >> --- >> directory/studio/branches/studio-tycho/plugins/schemaeditor/META-INF/MANIFEST.MF >> (original) >> +++ >> directory/studio/branches/studio-tycho/plugins/schemaeditor/META-INF/MANIFEST.MF >> Sun Oct 26 19:05:52 2014 >> @@ -6,12 +6,14 @@ Bundle-Version: 2.0.0.qualifier >> Bundle-SymbolicName: >> org.apache.directory.studio.schemaeditor;singleton:=true >> Bundle-License: http://www.apache.org/licenses/LICENSE-2.0.txt >> Bundle-RequiredExecutionEnvironment: JavaSE-1.6 >> +Bundle-Localization: plugin >> +Bundle-Activator: org.apache.directory.studio.schemaeditor.Activator >> Eclipse-LazyStart: true >> Export-Package: org.apache.directory.studio.schemaeditor >> -Import-Package: org.apache.commons.collections;version="3.2.1", >> - org.apache.commons.collections.map;version="3.2.1", >> - org.apache.commons.io;version="2.4", >> - org.apache.log4j;bundle-version="1.2.17", >> +Import-Package: org.apache.commons.collections, >> + org.apache.commons.collections.map, >> + org.apache.commons.io, >> + org.apache.log4j, >> org.dom4j, >> org.dom4j.io >> Require-Bundle: org.eclipse.core.runtime, >> >> Modified: >> directory/studio/branches/studio-tycho/plugins/valueeditors/META-INF/MANIFEST.MF >> URL: >> http://svn.apache.org/viewvc/directory/studio/branches/studio-tycho/plugins/valueeditors/META-INF/MANIFEST.MF?rev=1634381&r1=1634380&r2=1634381&view=diff >> ============================================================================== >> --- >> directory/studio/branches/studio-tycho/plugins/valueeditors/META-INF/MANIFEST.MF >> (original) >> +++ >> directory/studio/branches/studio-tycho/plugins/valueeditors/META-INF/MANIFEST.MF >> Sun Oct 26 19:05:52 2014 >> @@ -6,14 +6,16 @@ Bundle-Version: 2.0.0.qualifier >> Bundle-SymbolicName: >> org.apache.directory.studio.valueeditors;singleton:=true >> Bundle-License: http://www.apache.org/licenses/LICENSE-2.0.txt >> Bundle-RequiredExecutionEnvironment: JavaSE-1.6 >> +Bundle-Localization: plugin >> +Bundle-Activator: >> org.apache.directory.studio.valueeditors.ValueEditorsActivator >> Eclipse-LazyStart: true >> Export-Package: org.apache.directory.studio.valueeditors, >> org.apache.directory.studio.valueeditors.dn, >> org.apache.directory.studio.valueeditors.integer >> Import-Package: org.apache.commons.lang, >> - org.apache.commons.codec;bundle-version="1.8", >> - org.apache.commons.codec.binary;bundle-version="1.8", >> - org.apache.commons.io;bundle-version="2.4" >> + org.apache.commons.codec, >> + org.apache.commons.codec.binary, >> + org.apache.commons.io >> Require-Bundle: org.eclipse.core.runtime, >> org.apache.directory.api.ldap.model;bundle-version="1.0.0.M24", >> org.apache.directory.api.util;bundle-version="1.0.0.M24", >> >> >
