Hi Stefan, I can appreciate that increasing the distribution size from 12 -> 17 MB could be problematic. I am a maven user and so this kind of consideration does not affect me ;-) I'll leave it up to you, if you feel that this is a blocker then that's ok with me. However, IMO it is not an outrageous size increase.
If you are OK with the patch, then I'd like the change I made as part of the patch to be reviewed - namely associating the instanceId with the CacheManager, in case it has unintended consequences. Colm. On Sat, Dec 27, 2014 at 5:52 PM, Stefan Seelmann <[email protected]> wrote: > On 12/27/2014 04:54 PM, Stefan Seelmann wrote: > > On 12/27/2014 03:34 PM, Colm O hEigeartaigh wrote: > >>> what is the size of this new dependency? is it 10MB life Stefan > mentioned? > >>> > >> > >> It's 6.6 MB. I really don't think the size difference justifies using a > >> relatively ancient version of EhCache. > > > > Well, it would increase the ApacheDS binary distribution from now 12MB > > to 17 MB. So 6.6/17 ~= 1/3 used by the cache library from which we only > > use a small part of its functionality? On the other hand, Studio > > binaries size is more than 100MB ;) > > > > So I tested your patch. But I have an issue that when running mvn clean > > install of the whole ApacheDS project that the tests just hang, for > > example the ClientServerReplicationIT in server-integ. Running it alone > > works fine, but within the whole test suite it hangs. This test restarts > > the consumer service multiple times, so maybe there is an issue with > > cache initialization? Any idea? > > Nevermind, I run the test suite again (twice) and now it worked fine. > > Kind Regards, > Stefan > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com
