Le 02/04/15 21:53, Emmanuel Lécharny a écrit : > Hi Shawn, > > I now have something that is quite close to a release. Although I have a > couple of comments relative to some files present in the tarballs : > > - first, I see a LICENSE and NOTICE files being added, when those files > are not present in the code base. My guess is that they are generated > - second, there are also a LICENSE.txt and a NOTCE.txt files. I think we > should not have a LICENSE and a LICENSE.txt (same for NOTICE) > > Here, I suggest to get rid of the .txt files and rename them NOTICE and > LICENSE. > > I also added a LICENSE.cmdLineParser.txt file in which I have copied the > header of the cmdLineParser.java file. In the near future, I do think we > should get rid of this class, and use common-cli. FTR, I just pushed some modification for the release.
running mvn package -Papache-release will generate packages in the target directory. I think the fortress-core-1.0-RC40-SNAPSHOT-src* files are fine, and contain everything needed to build the project (including the required NOTICE/LICENSE files). I have some doubt about the fortress-core-1.0-RC40-SNAPSHOT-bin* tarballs, which contains a lib/ and a dist/ directories. First, I don't see why we have all the used libs beside the jar (either the user will not use those jars, and they are useless, or they want a standalone jar, which contains all the jars in one single file. In any case, we have to add the LICENSE.* files (2 are missing). We are not far, but there is a bit aof cleanup to do...
