[ 
https://issues.apache.org/jira/browse/DIRKRB-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486739#comment-14486739
 ] 

Lin Chen commented on DIRKRB-212:
---------------------------------

Hi Jiajia,
In the method {{testGet}}, how about asserting by:
{code}
KrbIdentity identity = backend.getIdentity(TEST_PRINCIPAL);
assertThat(identity).isNotNull();
assertThat(identity.getExpireTime()).isEqualTo(kid.getExpireTime());
assertThat(identity.isDisabled()).isEqualTo(kid.isDisabled());
assertThat(identity.getKeyVersion()).isEqualTo(kid.getKeyVersion());
for (EncryptionKey expectedKey : kid.getKeys()) {
    //...
}
{code}?
For in the way, we can avoid adding {{List<EncryptionKey> expectedKeys}} as a 
global variable. 

> Clear the identity cache before get the identity and add more asserts in 
> BackendTest
> ------------------------------------------------------------------------------------
>
>                 Key: DIRKRB-212
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-212
>             Project: Directory Kerberos
>          Issue Type: Improvement
>            Reporter: Jiajia Li
>            Assignee: Jiajia Li
>         Attachments: DIRKRB-212-V1.patch, DIRKRB-212-V2.patch
>
>
> In the test, if the cache not cleared before getting, we will get the 
> identity from cache but not backend.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to