[
https://issues.apache.org/jira/browse/DIRKRB-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518996#comment-14518996
]
Kai Zheng commented on DIRKRB-231:
----------------------------------
Good work Yaning! Would you simplify the following two blocks? Thanks.
{code}
+ if (isTcp) {
+ KrbMessage krbResponse = kdcRequest.getReply();
+ int bodyLen = krbResponse.encodingLength();
+ ByteBuffer responseMessage = ByteBuffer.allocate(bodyLen + 4);
+ responseMessage.putInt(bodyLen);
+ krbResponse.encode(responseMessage);
+ responseMessage.flip();
+ return responseMessage;
+ } else {
+ KrbMessage krbResponse = kdcRequest.getReply();
+ int bodyLen = krbResponse.encodingLength();
+ ByteBuffer responseMessage = ByteBuffer.allocate(bodyLen);
+ krbResponse.encode(responseMessage);
+ responseMessage.flip();
+ return responseMessage;
+ }
{code}
{code}
+ if (!isTcp) {
+ ByteBuffer requestMessage = ByteBuffer.allocate(bodyLen);
+ kdcReq.encode(requestMessage);
+ requestMessage.flip();
+ try {
+ sendMessage(kdcRequest, requestMessage);
+ } catch (IOException e) {
+ throw new KrbException("sending message failed", e);
+ }
+ } else {
+ ByteBuffer requestMessage = ByteBuffer.allocate(bodyLen + 4);
+ requestMessage.putInt(bodyLen);
+ kdcReq.encode(requestMessage);
+ requestMessage.flip();
+ try {
+ sendMessage(kdcRequest, requestMessage);
+ } catch (IOException e) {
+ throw new KrbException("sending message failed", e);
+ }
{code}
> Support UDP transport for NettyKdcNetwork
> -----------------------------------------
>
> Key: DIRKRB-231
> URL: https://issues.apache.org/jira/browse/DIRKRB-231
> Project: Directory Kerberos
> Issue Type: New Feature
> Reporter: Kai Zheng
> Assignee: Xu Yaning
> Attachments: DIRKRB-231-v1.patch
>
>
> This is TODO left to be done.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
