[
https://issues.apache.org/jira/browse/DIRKRB-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521235#comment-14521235
]
Lin Chen commented on DIRKRB-226:
---------------------------------
Good work. Two minor questions:
1. Could you please refine the code style below:
{code}
+ if (kOptions.contains(KadminOption.FORCE)) {
+ renamePrincipal();
+ }
+ else {
{code}
2. The lines: {{String reply}} and {{reply = ...}} could be combined together
here.
{code}
+ String reply;
+ String prompt = "Are you sure want to rename the principal?
(yes/no, YES/NO, y/n, Y/N) ";
+ reply = KadminTool.getReplay(prompt);
{code}
> Enhance kadmin to supoort rename principal
> ------------------------------------------
>
> Key: DIRKRB-226
> URL: https://issues.apache.org/jira/browse/DIRKRB-226
> Project: Directory Kerberos
> Issue Type: New Feature
> Reporter: Jiajia Li
> Assignee: Wei Zhou
> Attachments: DIRKRB-226-V1.patch, DIRKRB-226-V2.patch
>
>
> Enhance kadmin tool to supoort rename principal
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
