[
https://issues.apache.org/jira/browse/DIRKRB-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532222#comment-14532222
]
Kai Zheng commented on DIRKRB-230:
----------------------------------
Hi Yaning,
Thanks for your update.
1. Ref. the following codes, I thought it should call {{onNewTransport}} when
it's not new but from the cache.
{code}
+ InetSocketAddress fromAddress = (InetSocketAddress)
udpServer.receive(recvBuffer);
+ if (fromAddress != null) {
+ recvBuffer.flip();
+ KdcUdpTransport transport = transports.get(fromAddress);
+ if (transport == null) {
+ transport = new KdcUdpTransport(udpServer, fromAddress);
+ }
+ transport.onRecvMessage(recvBuffer);
+ onNewTransport(transport);
+ recvBuffer = ByteBuffer.allocate(65507);
+ }
{code}
2. With below, why have the TODO, for what?
{code}
+ recvBuffer = ByteBuffer.allocate(65507); // TODO.
{code}
3. It's good to see {{OnlyUdpKdcTest}}, I thought it's for the default
KdcNetwork implementation in the library level. In Kerby KDC level for the
NettyKdcNetwork, could we add one similarly? Thanks!
> Support UDP transport for default KdcNetwork
> --------------------------------------------
>
> Key: DIRKRB-230
> URL: https://issues.apache.org/jira/browse/DIRKRB-230
> Project: Directory Kerberos
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Xu Yaning
> Attachments: DIRKRB-230-v1.patch, DIRKRB-230-v2.patch
>
>
> This is TODO to be left done.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
