[
https://issues.apache.org/jira/browse/DIRSTUDIO-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562648#comment-14562648
]
Paul Richardson commented on DIRSTUDIO-1046:
--------------------------------------------
Hi [~seelmann]
Go ahead and correct the class formatting. Apologies I hadn't already done it.
So having eliminated the ShowBookmark and ShowSearches actions from the UI, I
have now been able to remove any dependency on the ldapbrowser.ui plugin.
That does mean of course that the bug no longer occurs in our code, although
the patch may still be useful to you.
> EntryEditorManager constructor can throw NPE
> --------------------------------------------
>
> Key: DIRSTUDIO-1046
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-1046
> Project: Directory Studio
> Issue Type: Bug
> Components: studio-ldapbrowser
> Affects Versions: 2.0.0-M8 (2.0.0.v20130628)
> Reporter: Paul Richardson
> Attachments:
> replace-active-workbench-calls-in-EntryEditorManager-v2.diff,
> replace-active-workbench-calls-in-EntryEditorManager.diff
>
>
> Using the BrowserWidget in a wizard rather than the BrowserView can result in
> a NullPointerException being thrown.
> The BrowseWidget is embedded in a WizardPage so the
> org.apache.directory.ldapbrowser.ui plugin has not necessarily been
> activated. However, during a refresh of the BrowserWidget's tree view, a
> worker-runnable calls on resources of the ldapbrowser.ui plugin and it is
> activated.
> The activation of the ldapbrowser.ui plugin calls
> {code}
> entryEditorManager = new EntryEditorManager();
> {code}
> The constructor of the EntryEditorManager contains
> {code}
> PlatformUI.getWorkbench().getActiveWorkbenchWindow().getPartService().addPartListener(
> partListener );
> {code}
> This code only works if called from the UI thread. Otherwise,
> getActiveWorkbenchWindow() returns null hence the NPE.
> Since a runnable is responsible for the plugin activation in this use-case
> then this behaviour occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
