[ 
https://issues.apache.org/jira/browse/DIRKRB-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570357#comment-14570357
 ] 

Lin Chen commented on DIRKRB-227:
---------------------------------

Hi Liqi, the patch looks good! A minor thing, in the codes below:
{code}
+        IdentityBackend backend = KadminTool.getBackend(backendConfig);
+        KrbIdentity identity = backend.getIdentity(principal);
+        identity.addKeys(generateKeys(identity.getPrincipalName(), password));
{code}
{{backend.getIdentity()}} would return {{null}} if it can not find the 
principal. Maybe there should be a judgement?

> Enhance kadmin to support change password for principal
> -------------------------------------------------------
>
>                 Key: DIRKRB-227
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-227
>             Project: Directory Kerberos
>          Issue Type: New Feature
>            Reporter: Jiajia Li
>            Assignee: Liqi Yi
>         Attachments: DIRKRB-227.001.patch
>
>
> Enhance kadmin to support change password for principal.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to