[ 
https://issues.apache.org/jira/browse/DIRKRB-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593058#comment-14593058
 ] 

Stefan Seelmann commented on DIRKRB-291:
----------------------------------------

Indeed the patch look good.

Just one thing, the line
{code}
+            entry.add( "createTimestamp",
+                    toGeneralizedTime(identity.getCreatedTime()));
{code}
should be removed. The 'createTimestamp' attribute is an operational attribute 
that is maintained by the server. The client is not allowed to set/change it. I 
think it only works in your test because you use an admin account.


> Implementing doAddIdentity for LdapIdentityBackend
> --------------------------------------------------
>
>                 Key: DIRKRB-291
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-291
>             Project: Directory Kerberos
>          Issue Type: Sub-task
>            Reporter: Xu Yaning
>            Assignee: Xu Yaning
>         Attachments: DIRKRB-291-v1.patch, DIRKRB-291-v2.patch, 
> DIRKRB-291-v3.patch
>
>
> Impelmenting doAddIdentity for kerby to store new identity.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to