[
https://issues.apache.org/jira/browse/DIRKRB-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624376#comment-14624376
]
Lin Chen edited comment on DIRKRB-349 at 7/13/15 8:44 AM:
----------------------------------------------------------
The patch looks good. One minor thing:
{code}
- if (aValue != null) {
- if (aValue instanceof Asn1Item) {
- addItem((Asn1Item) aValue);
- } else {
- addItem(aValue);
- }
+ addItem((Asn1Item) aValue);
{code}
The cast in {{addItem((Asn1Item) aValue)}} seems to be redundant.
was (Author: hazelc):
The patch looks good. One minor thing:
{code}
- if (aValue != null) {
- if (aValue instanceof Asn1Item) {
- addItem((Asn1Item) aValue);
- } else {
- addItem(aValue);
- }
+ addItem((Asn1Item) aValue);
{code}
The cast in {{ addItem((Asn1Item) aValue)}} seems to be redundant.
> Fix findbugs Problems for kerby-asn1 module
> -------------------------------------------
>
> Key: DIRKRB-349
> URL: https://issues.apache.org/jira/browse/DIRKRB-349
> Project: Directory Kerberos
> Issue Type: Sub-task
> Reporter: Xu Yaning
> Assignee: Xu Yaning
> Attachments: DIRKRB-349-v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
