Xu Yaning created DIRKRB-368:
--------------------------------

             Summary: Fix findbugs Problems for kerby-tool module
                 Key: DIRKRB-368
                 URL: https://issues.apache.org/jira/browse/DIRKRB-368
             Project: Directory Kerberos
          Issue Type: Sub-task
            Reporter: Xu Yaning


Findbugs maven plugin reports the following problems:

# *org.apache.kerby.kerberos.tool.kinit.KinitOption.setDescription(String)* 
unconditionally sets the field description;
# *org.apache.kerby.kerberos.tool.kinit.KinitOption.setName(String)* 
unconditionally sets the field name;
# *org.apache.kerby.kerberos.tool.kinit.KinitOption.setType(KOptionType)* 
unconditionally sets the field type;
# *org.apache.kerby.kerberos.tool.kinit.KinitOption.setValue(Object)* 
unconditionally sets the field value;
# *org.apache.kerby.kerberos.tool.klist.KlistOption.setDescription(String)* 
unconditionally sets the field description;
# *org.apache.kerby.kerberos.tool.klist.KlistOption.setName(String)* 
unconditionally sets the field name;
# *org.apache.kerby.kerberos.tool.klist.KlistOption.setType(KOptionType)* 
unconditionally sets the field type;
# *org.apache.kerby.kerberos.tool.klist.KlistOption.setValue(Object)* 
unconditionally sets the field value.
# Dead store to error in 
*org.apache.kerby.kerberos.tool.kinit.KinitTool.main(String[])*;
# Found reliance on default encoding in 
*org.apache.kerby.kerberos.tool.kinit.KinitTool.getPassword(String)*: new 
java.util.Scanner(InputStream);
# 
*org.apache.kerby.kerberos.tool.klist.KlistTool.printCredentialCacheInfo(KOptions)*
 may fail to clean up java.io.InputStream;
# Found reliance on default encoding in 
*org.apache.kerby.kerberos.tool.token.TokenCache.readToken(String)*: new 
java.io.FileReader(File);
# Found reliance on default encoding in 
*org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)*: new 
java.io.FileWriter(File);
# *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)* may fail 
to clean up java.io.Writer on checked exception;
# Exceptional return value of java.io.File.delete() ignored in 
*org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)*;
# Exceptional return value of java.io.File.setWritable(boolean, boolean) 
ignored in *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)*;

Problems 1 to 8 are required to be fixed in DIRKRB-367, the others are to be 
fixed here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to