[
https://issues.apache.org/jira/browse/DIRKRB-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627419#comment-14627419
]
Jiajia Li commented on DIRKRB-354:
----------------------------------
V3 is fine, I've committed. Thanks for Yaning's work.
commit 0d7b34f93588ff7b81fc9fe8c81ea185d3d26e31
Author: plusplusjiajia <[email protected]>
Date: Wed Jul 15 10:24:13 2015 +0800
[DIRKRB-354]-Fix getBooleanOption return null problem. Contributed by
Yaning.
> Fix getBooleanOption return null problem
> ----------------------------------------
>
> Key: DIRKRB-354
> URL: https://issues.apache.org/jira/browse/DIRKRB-354
> Project: Directory Kerberos
> Issue Type: Bug
> Reporter: Xu Yaning
> Assignee: Xu Yaning
> Attachments: DIRKRB-354-v1.patch, DIRKRB-354-v2.patch,
> DIRKRB-354-v3.patch
>
>
> org.apache.kerby.KOptions.getBooleanOption(KOption) has Boolean return type
> and returns explicit null; A method that returns either Boolean.TRUE,
> Boolean.FALSE or null is an accident waiting to happen. This method can be
> invoked as though it returned a value of type boolean, and the compiler will
> insert automatic unboxing of the Boolean value. If a null value is returned,
> this will result in a NullPointerException.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
