[
https://issues.apache.org/jira/browse/DIRKRB-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiajia Li updated DIRKRB-349:
-----------------------------
Description:
-<file classname="org.apache.kerby.asn1.type.AbstractAsn1Type">
<BugInstance lineNumber="447" message="Bad comparison of nonnegative value with
0 in org.apache.kerby.asn1.type.AbstractAsn1Type.readLength(LimitedByteBuffer)"
category="CORRECTNESS" priority="Normal"
type="INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE"/>
</file>
-<file classname="org.apache.kerby.asn1.type.Asn1BmpString">
<BugInstance lineNumber="30" message="Non-virtual method call in new
org.apache.kerby.asn1.type.Asn1BmpString() passes null for non-null parameter
of new Asn1Simple(UniversalTag)" category="CORRECTNESS" priority="High"
type="NP_NULL_PARAM_DEREF_NONVIRTUAL"/>
</file>
-<file classname="org.apache.kerby.asn1.type.Asn1Choice">
<BugInstance lineNumber="38" message="new
org.apache.kerby.asn1.type.Asn1Choice(Asn1FieldInfo[]) may expose internal
representation by storing an externally mutable object into
Asn1Choice.fieldInfos" category="MALICIOUS_CODE" priority="Normal"
type="EI_EXPOSE_REP2"/>
</file>
-<file classname="org.apache.kerby.asn1.type.Asn1Collection">
<BugInstance lineNumber="85" message="instanceof will always return true for
all non-null values in
org.apache.kerby.asn1.type.Asn1Collection.decodeBody(LimitedByteBuffer), since
all org.apache.kerby.asn1.type.Asn1Item are instances of
org.apache.kerby.asn1.type.Asn1Item" category="STYLE" priority="Normal"
type="BC_VACUOUS_INSTANCEOF"/>
</file>
-<file classname="org.apache.kerby.asn1.type.Asn1CollectionType">
<BugInstance lineNumber="39" message="new
org.apache.kerby.asn1.type.Asn1CollectionType(int, Asn1FieldInfo[]) may expose
internal representation by storing an externally mutable object into
Asn1CollectionType.fieldInfos" category="MALICIOUS_CODE" priority="Normal"
type="EI_EXPOSE_REP2"/>
</file>
> Fix findbugs Problems for kerby-asn1 module
> -------------------------------------------
>
> Key: DIRKRB-349
> URL: https://issues.apache.org/jira/browse/DIRKRB-349
> Project: Directory Kerberos
> Issue Type: Sub-task
> Reporter: Xu Yaning
> Assignee: Xu Yaning
> Attachments: DIRKRB-349-v1.patch, DIRKRB-349-v2.patch
>
>
> -<file classname="org.apache.kerby.asn1.type.AbstractAsn1Type">
> <BugInstance lineNumber="447" message="Bad comparison of nonnegative value
> with 0 in
> org.apache.kerby.asn1.type.AbstractAsn1Type.readLength(LimitedByteBuffer)"
> category="CORRECTNESS" priority="Normal"
> type="INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE"/>
> </file>
> -<file classname="org.apache.kerby.asn1.type.Asn1BmpString">
> <BugInstance lineNumber="30" message="Non-virtual method call in new
> org.apache.kerby.asn1.type.Asn1BmpString() passes null for non-null parameter
> of new Asn1Simple(UniversalTag)" category="CORRECTNESS" priority="High"
> type="NP_NULL_PARAM_DEREF_NONVIRTUAL"/>
> </file>
> -<file classname="org.apache.kerby.asn1.type.Asn1Choice">
> <BugInstance lineNumber="38" message="new
> org.apache.kerby.asn1.type.Asn1Choice(Asn1FieldInfo[]) may expose internal
> representation by storing an externally mutable object into
> Asn1Choice.fieldInfos" category="MALICIOUS_CODE" priority="Normal"
> type="EI_EXPOSE_REP2"/>
> </file>
> -<file classname="org.apache.kerby.asn1.type.Asn1Collection">
> <BugInstance lineNumber="85" message="instanceof will always return true for
> all non-null values in
> org.apache.kerby.asn1.type.Asn1Collection.decodeBody(LimitedByteBuffer),
> since all org.apache.kerby.asn1.type.Asn1Item are instances of
> org.apache.kerby.asn1.type.Asn1Item" category="STYLE" priority="Normal"
> type="BC_VACUOUS_INSTANCEOF"/>
> </file>
> -<file classname="org.apache.kerby.asn1.type.Asn1CollectionType">
> <BugInstance lineNumber="39" message="new
> org.apache.kerby.asn1.type.Asn1CollectionType(int, Asn1FieldInfo[]) may
> expose internal representation by storing an externally mutable object into
> Asn1CollectionType.fieldInfos" category="MALICIOUS_CODE" priority="Normal"
> type="EI_EXPOSE_REP2"/>
> </file>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
