[
https://issues.apache.org/jira/browse/DIRKRB-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627481#comment-14627481
]
Jiajia Li commented on DIRKRB-357:
----------------------------------
Hi Yaning, I think it's better to throw exception if can't create directory for
dataLogFile and dataFile. For example:
{code}
if (!dataLogFile.exists()) {
if(!dataLogFile.mkdirs()) {
throw exception......
}
{code}
> Fix findbugs Problems for kerby-backend
> ---------------------------------------
>
> Key: DIRKRB-357
> URL: https://issues.apache.org/jira/browse/DIRKRB-357
> Project: Directory Kerberos
> Issue Type: Sub-task
> Reporter: Xu Yaning
> Attachments: DIRKRB-357-v1.patch, DIRKRB-357-v2.patch
>
>
> Fix findbugs Problems for kerby-backend. The findbugs maven plugin reports
> the following problems:
> # Boxing/unboxing to parse a primitive
> *org.apache.kerby.kerberos.kdc.identitybackend.typeAdapter.KerberosTimeAdapter.deserialize(JsonElement,
> Type, JsonDeserializationContext)*;
> # Should
> *org.apache.kerby.kerberos.kdc.identitybackend.LdapIdentityBackend$KeysInfo*
> be a _static_ inner class?;
> # Exceptional return value of java.io.File.mkdirs() ignored in new
> *org.apache.kerby.MavibotBackend(File)*;
> # Exceptional return value of java.io.File.mkdirs() ignored in
> *org.apache.kerby.kerberos.kdc.identitybackend.ZookeeperIdentityBackend.init()*.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
