On 07/27/2015 12:56 AM, Emmanuel Lécharny wrote:
> Le 26/07/15 20:57, Stefan Seelmann a écrit :
>> On 07/20/2015 10:08 PM, Stefan Seelmann wrote:
>>> Hi all,
>>>
>>> I tuned our checkstyle configuration [1] according to our code formatter
>>> and fixed lots of (sensible) violations in API.
>>>
>>> I'd like to enable checkstyle checks for the API project and let the
>>> build fail on violations. Very same as we did for Kerby. Only the checks
>>> will be activated, no report generation in enabled because that is quite
>>> useless. Later other projects may follow.
>>>
>>> For that I need to release the checkstyle-configuration [1] project
>>> first, then the our project parent POM.
>> Done. For the API project checkstyle check is now enabled and the build
>> fails on violations. You can skip checkstyle checks with by setting
>> -Dcheckstyle.skip property.
>
> Hi Stefan,
>
> I just ran the API build after having updated my env with your change,s
> and I get no error and no fails.
>
> How did you run it ?
The checks run with the normal build within the validate phase, see
Maven output:
[INFO] --- maven-checkstyle-plugin:2.16:check (validate)
The API project currently has no errors, all violoations are fixed. Only
if one introduces new errors the build will fail.
Oh, on Jenkins the build failed, it seems the checkstyle plugin checked
the generated Antlr sources, they need to be excluded, I'll check.
For the other projects I'd suggest to configure the checkstyle plugin to
only print errors, but not to fail the build.
Kind Regards,
Stefan
