[
https://issues.apache.org/jira/browse/DIRSERVER-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697897#comment-14697897
]
lucas theisen commented on DIRSERVER-2088:
------------------------------------------
This is mostly a complete solution. The only thing I still want to do here is
figure out answers to the following questions:
# Is it a good idea to specify default values in the {{@ConfigurationElement}}
annotation (see [this
comment|https://issues.apache.org/jira/browse/DIRSERVER-2088?focusedCommentId=14697460&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14697460])
# This new version ({{ConfigurableHashingInterceptor}}) is fully capable of
replacing all the other implementations with just configuration. Do we want to
remove them, or leave them in place?
# Are the oid's I chose good enough?
## *objectClass ads-hashInterceptor*: m-oid=1.3.6.1.4.1.18060.0.4.1.3.132
## *attributeType ads-hashAlgorithm*: m-oid=1.3.6.1.4.1.18060.0.4.1.2.132.0
## *attributeType ads-hashAttribute*: m-oid=1.3.6.1.4.1.18060.0.4.1.2.132.1
# Are the new schema ldifs missing anything?
# And finally, in the existing implementation of of the base class
{{PasswordHashingInterceptor}}, the attributes were checked and _replaced_ with
a hashed version. My implementation actually modifies the existing attribute
itself. It passes all the unit tests, but I do not know if there was a reason
why the existing code creates a new attribute. Any ideas?
> Add the ability to specify additional fields that should be hashed by the
> hashing interceptors
> ----------------------------------------------------------------------------------------------
>
> Key: DIRSERVER-2088
> URL: https://issues.apache.org/jira/browse/DIRSERVER-2088
> Project: Directory ApacheDS
> Issue Type: Improvement
> Reporter: lucas theisen
> Attachments: oid_map.json, oid_map.pl
>
>
> This
> [discussion|http://mail-archives.apache.org/mod_mbox/directory-dev/201507.mbox/%3cbn1pr09mb019635837eb5b0c564a0e955cd...@bn1pr09mb0196.namprd09.prod.outlook.com%3E]
> went over the topic. Per the suggestion from [~akiran], this should be done
> with some new attributes:
> {quote}
> what I would do is to add support for configuring one or more attributes in
> this interceptor
> something like, 'ads-hashAttibute' a multi valued attributes
> {quote}
> Per [~elecharny], a new {{objectClass}} should be created:
> {quote}
> The idea is to add some configuration in the HashInterceptor
> configuration. You can create a new ObjectClass for that and add some
> new AttributeType to store the OID to be hashed.
> {quote}
> And given that we will create a new {{objectClass}} with its own
> configuration attribute for {{ads-hashAttribute}} it is also reasonable to
> add {{ads-hashAlgorithm}}. With this, _ALL_ of the individual classes could
> be implemented as one simple {{HashingInterceptor}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
