[
https://issues.apache.org/jira/browse/FC-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984031#comment-14984031
]
Shawn McKinney commented on FC-122:
-----------------------------------
Hello Yudhi,
Welcome! Your pull request is gladly accepted. I did add a few items to your
fix:
1. in addition to your replacement of commons-httpclient:commons-httpclient rev
3.1 with org.apache.httpcomponents:httpclient:jar rev 4.5.1, I had to add
org.apache.httpcomponents:httpcore:jar rev 4.4.3
2. upgrade to version.commons.codec>1.10
3. upgrade/change to version.cxf.common.utilities>2.7.17
4. replace javax.ws.rs:jsr311-api with version.javax.ws.rs-api>2.0.1
5. change the dependencies used in the maven-ant-plugin further down the pom.xml
6. apply all of these changes to our old ant build.xml because unfortunately
we're still dependent on ant for some parts of the build process.
So far everything looks good. The code builds and junit tests runs cleanly on
latest fortress-rest snapshot against the apache directory. Because this is a
pretty big change, we'll need to keep an eye on things for a while to make sure
it doesn't break something downstream.
Thanks very much for your help. It is appreciated.
Shawn
> Use latest httpclient from apache httpcomponents since common-httpclient is
> not maintained anymore
> --------------------------------------------------------------------------------------------------
>
> Key: FC-122
> URL: https://issues.apache.org/jira/browse/FC-122
> Project: FORTRESS
> Issue Type: Improvement
> Affects Versions: 1.0.0-RC41
> Reporter: Yudhi Karunia Surtan
>
> I think current RestUtil class need to adapt to using the latest httpclient
> from apache.
> Is it possible to introduce a method which can have HttpClient interface as a
> parameter at this class(RestUtil)?
> I'm not sure how we will implement all other *MgrRestImpl class will deal
> with that parameter, but since this class is an Utility class, i think we can
> figure it later about the strategy for user to inject their own HttpClient
> implementation with their prefered ClientConnectionManager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
