[
https://issues.apache.org/jira/browse/DIRKRB-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059514#comment-15059514
]
Lin Chen commented on DIRKRB-499:
---------------------------------
The patch looks great, a minor issue:
When we add a set of data to a list, maybe it is better to use
{{list.addAll(set)}} or {{new ArrayList<>(set)}} than add the data one by one.
For example, in the method {{public List<String> getSections()}}, we can write
like:
{code}
List<String> al = new ArrayList<String>(items.keySet());
{code}
Hope it is helpful to you.:)
> A complete krb5 conf file parser
> --------------------------------
>
> Key: DIRKRB-499
> URL: https://issues.apache.org/jira/browse/DIRKRB-499
> Project: Directory Kerberos
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: YanYan
> Attachments: DIRKRB-499-v1.patch, DIRKRB-499-v2.patch
>
>
> Currently we don't yet support krb5.conf or kdc.conf file format completely
> and some advanced functionalities are not able to work yet. The current
> approach is regarding the format as an *INI* file format, therefore it's much
> limited. We need a decent krb5 format conf file parser that conforms exactly
> to MIT kerberos.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
