[
https://issues.apache.org/jira/browse/DIRKRB-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15073500#comment-15073500
]
Lin Chen commented on DIRKRB-505:
---------------------------------
Thanks Yan for the great work! An issue:
When we traversal a map, we can add the concrete type to the iterator, such
that we do not need to cast objects. For example,
{code}
Iterator<Map.Entry<String, Object>> iter = mapConfig.entrySet().iterator();
Map.Entry entry = iter.next();
String key = entry.getKey();
{code}
What's more, a simpler way, we can use 'foreach' loop to replace 'while' when
traversalling a map.
And another minor issue:
{code}
if (value instanceof String) {
config.set(key, (String) value);
}
{code}
It seems that there are two spaces between {{value}} and {{String}}. :)
> Apply Krb5Parser to both kerb-server and kerb-client
> ----------------------------------------------------
>
> Key: DIRKRB-505
> URL: https://issues.apache.org/jira/browse/DIRKRB-505
> Project: Directory Kerberos
> Issue Type: Improvement
> Reporter: YanYan
> Assignee: YanYan
> Attachments: DIRKBB-505-v1.patch
>
>
> As a result of having a complete Krb5Parser, we are able to replace old
> methods of adding krb5 format config file with methods in provided in the
> parser. The modification will be in both server part and client part.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
