I have to vote -1. The blocker is that fortress-rest.war and fortress-web.war don't include required licenses and notices. * slf4j: permission notice needs to be included in LICENSE file * accelerator: OpenLDAP license needs to be included in LICENSE file * for CDDL licensed software (javaee-api, javax.mail) the CDDL license also needs to be inluded in LICENSE file * The NOTICE file is not up-to-date * maybe more, to be checked.
@Emmanuel: please correct me if I'm wrong. Other issues: realm: * remove LICENSE-UnboundID-LDAPSDK.txt and LICENSE-unboundid-ldapsdk-2.1.0-se.txt in lib folder and from pom.xml web: * jhighlight seems to be unused, and as it is CDDL, I'd recommend to remove it * WAR file contains all the test dependencies (junit, hamcrest, selenium), I don't think that's required? * realm, rest, and web source packages contain duplicate LICENSE and LICENSE.txt as well as NOTICE and NOTICE.txt files. I guess one of each is generated, maybe that can be avoided? In general I'd recommend to append the required licenses to the main LICENSE file and remove additional license files in lib folder. Consider upgrade of depencencies, e.g. spring 3.2.3 -> 3.2.16 (if 4 is not possible) Kind Regards, Stefan On 03/09/2016 03:54 PM, Shawn McKinney wrote: > Hello, > > This vote is for the release of Apache Directory Fortress 1.0-RC42. > > Since it's been almost a year since the last release, and even then it was > just the core and not the rest (pun intended:), there's a long list of fixed > issues - over 50: > https://issues.apache.org/jira/issues/?jql=fixVersion%20%3D%201.0.0-RC41%20AND%20project%20%3D%20FC > > A temporary tag has been created (and can be removed if the vote is not > approved). > > Nexus has been used for the preps and all final artifacts are stored in a > staging repository: > https://repository.apache.org/content/repositories/orgapachedirectory-1084 > > The distributions are available for download: > http://home.apache.org/~smckinney/ > > If you are to test, you may follow either one of these README’s, located in > the root folder of the core: > 1. Test with Apache Directory Server: > https://github.com/apache/directory-fortress-core/blob/master/README-TEN-MINUTE-GUIDE.md > 2. Test with OpenLDAP Directory Server: > https://github.com/apache/directory-fortress-core/blob/master/README-QUICKSTART-SLAPD.md > > For either you must substitute this step: > Clone the directory-fortress repos from apache git by commands: > > with this one: > extract that particular component's source-release package > > after that instructions should be the same. > > Let us vote: > [ ] +1 | Release Fortress core, realm, rest and web 1.0-RC42 > [ ] +/- | Abstain > [ ] -1 | Do *NOT* Release Fortress core, realm, rest and web 1.0-RC42 > > Thanks for the help getting to this point, it's been an adventure... :-) > > Shawn > > > >
