[ 
https://issues.apache.org/jira/browse/DIRKRB-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299643#comment-15299643
 ] 

Jiajia Li commented on DIRKRB-542:
----------------------------------

The update of the latest patch is great, with nice code format and with more 
RFC definitions.
The unit test for AD looks good to me and I can pass all the tests through the 
command "mvn clean package -Pnochecks",
I think the patch will be better if you can fix some pmd issues, you can run 
"mvn clean package" to find the pmd issues.

> Kerby Authorization
> -------------------
>
>                 Key: DIRKRB-542
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-542
>             Project: Directory Kerberos
>          Issue Type: Sub-task
>            Reporter: Gerard Gagliano
>            Assignee: Gerard Gagliano
>         Attachments: ADAll.patch, ad.patch, ad2.patch, ad3.patch, adtest.patch
>
>
> Kerby lacks Authorization classes.  Authorization types from RFC 1510, 4120, 
> 4537, 4556, 6711 and 7751 will greatly enhance the usability of Kerby.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to