[
https://issues.apache.org/jira/browse/DIRKRB-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318135#comment-15318135
]
YanYan commented on DIRKRB-580:
-------------------------------
Hi Qing,
I think this is a great patch!
The logic is good, and you managed to change few codes to adjust this new list
feature.
I also saw the "RemoteAdminTool: " as a PROMT in the running tool, which sounds
nice to me.
some minor issues:
1. {{List_principal}} differs from other commands (such as {{add_principal}})
for that whether the command has an argument (the regular expression) or not
can legally be executed.
This causes a problem: when user first enter "list_principals", the running
tool will list all the principals in backend. Then the user will never know
there is a {{list_principals + expression}} usage.
Currently I couldn't think of a perfect way to solve this. [~jiajia], could you
give us some advice?
2. In {{AdminMessageType}}, you add {{GRT_PRINC_REQ}}, I thought you mean
{{GET_PRINC_REQ}} ?
It would be better if you could change that:)
3. I saw you add an {{infoPackageTool}} method in {{AdminServerHandler}}, to
deal with the redundant codes.
Maybe you can also refine {{handleAddPrincipalReq}},
{{handleDeletePrincipalReq}}, {{HandleRenamePrincipalReq}} with your new added
method.
> Implement list_principals in Remote Kadmin
> ------------------------------------------
>
> Key: DIRKRB-580
> URL: https://issues.apache.org/jira/browse/DIRKRB-580
> Project: Directory Kerberos
> Issue Type: Task
> Reporter: ChenQing
> Priority: Minor
> Attachments: DIRKRB-580-v1.patch
>
>
> Use XDR to encode and decode Remote Kadmin Request to implement get principal
> list function.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
