[ 
https://issues.apache.org/jira/browse/DIRSTUDIO-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seelmann resolved DIRSTUDIO-1130.
----------------------------------------
    Resolution: Fixed

Great finding and thanks for the patch, applied here: 
http://svn.apache.org/viewvc?rev=1771513&view=rev



> Password from Keystore not used
> -------------------------------
>
>                 Key: DIRSTUDIO-1130
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-1130
>             Project: Directory Studio
>          Issue Type: Bug
>          Components: studio-connection, studio-ldapbrowser
>    Affects Versions: 2.0.0-M12
>         Environment: OS: Ubuntu 16.04 64bit
> OpenJDK 64-Bit 1.8.0_111
>            Reporter: Mathias Frohna
>              Labels: keystore, password
>             Fix For: 2.0.0-M13
>
>         Attachments: apacheDS-storeBug
>
>
> When password keystore (with a master password) is enabled and a password for 
> a ldap connection should be stored this is ignored. Instead a dialog window 
> asking for the password is shown every time.
> If password keystore is not enabled (so passwords will be stored in plain 
> text) everything is fine.
> I tried to hunt down the bug and it should be in UIAuthHandler, following 
> Patch helped for me:
> Index: UIAuthHandler.java
> --- UIAuthHandler.java Base (BASE)
> +++ UIAuthHandler.java Locally Modified (Based On LOCAL)
> @@ -73,7 +73,7 @@
>                  String password = 
> passwordsKeyStoreManager.getConnectionPassword( connectionParameter.getId() );
>  
>                  // Checking if the bind password is available (the user 
> chose to store the password)
> -                if ( Strings.isEmpty( password ) ) //$NON-NLS-1$
> +                if ( !Strings.isEmpty( password ) ) //$NON-NLS-1$
>                  {
>                      return new Credentials( 
> connectionParameter.getBindPrincipal(),
>                          password, connectionParameter );



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to