[
https://issues.apache.org/jira/browse/DIRSTUDIO-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15776956#comment-15776956
]
Stefan Seelmann commented on DIRSTUDIO-1133:
--------------------------------------------
Good catch, that condition doesn't makes sense.
The reason why no NPE happened is that filterList is never null. So I just
removed the null check and made it final (plus some other changes):
http://svn.apache.org/viewvc?rev=1776025&view=rev
> Potential NPE issue
> -------------------
>
> Key: DIRSTUDIO-1133
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-1133
> Project: Directory Studio
> Issue Type: Bug
> Reporter: Jaechang Nam
> Priority: Minor
>
> It seems there is an incorrect condition in if statement "else if (
> filterList != null || !filterList.isEmpty() )". (still existing in the
> current snapshot, 1bf525559583e7469149038fa58adeffb2b5a246). If filterList is
> null, it would cause NPE.
> {code}
> 256 public LdapFilter getFilter( int offset )
> 257 {
> 258 if ( startToken != null && startToken.getOffset() == offset )
> 259 {
> 260 return parent;
> 261 }
> 262 else if ( filterList != null || !filterList.isEmpty() )
> 263 {
> 264 for ( Iterator<LdapFilter> it = filterList.iterator();
> it.hasNext(); )
> 265 {
> 266 LdapFilter filter = it.next();
> 267 if ( filter != null && filter.getFilter( offset ) != null
> )
> 268 {
> 269 return filter.getFilter( offset );
> 270 }
> 271 }
> 272 return null;
> 273 }
> 274 else
> 275 {
> 276 return null;
> 277 }
> 278 }
> {code}
> The indented code was this?
> {code}
> 262 else if ( filterList != null && !filterList.isEmpty() )
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
